Update-recency-based inclusion logic tests #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a channel has only recently become bidirectional, but there has not been a new update in the old direction since the last sync, the latest update in the old direction must still be included in full because it is the first time the full channel is being snapshotted.
arik-so
force-pushed
the
announcement-history-tests
branch
from
14bc952 to
52853c4
Compare
TheBlueMatt
reviewed
Nov 11, 2023
| { // seed the db | ||
| let announcement = generate_announcement(short_channel_id); | ||
| let update_1 = generate_update(short_channel_id, false, timestamp, 0, 0, 0, 6, 0); | ||
| let update_2 = generate_update(short_channel_id, true, timestamp + 1, 0, 0, 0, 3, 0); |
There was a problem hiding this comment.
These tests would be more readable if you left a one second gap between the "before last seen" and "after last seen" timestamps. As is the test assumes that anything with a timestamp equal to last query is included in a new update.
TheBlueMatt
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first channel update in a given direction was seen after (or at the exact second as) the last sync, the channel announcement and full updates in both directions should be included, even if one of the channels hasn't been updated since the last sync.
Conversely, if updates in both directions had been seen prior to the last sync, only the updates channel should be included, and only incrementally (unless all 5 properties changed).