Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esplora-client to 0.11 #3348

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Oct 3, 2024

Bump esplora-client to 0.11
.. the most-recent release, which also dropped the async-std dependency in favor of a default sleeper implementation using tokio.

This is needed for compatibility with upcoming BDK versions.

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (d49a08a) to head (4d9bcf1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   89.59%   89.55%   -0.04%     
==========================================
  Files         127      127              
  Lines      103438   103438              
  Branches   103438   103438              
==========================================
- Hits        92672    92631      -41     
- Misses       8049     8082      +33     
- Partials     2717     2725       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnull
Copy link
Contributor Author

tnull commented Oct 3, 2024

Might want to hold off until they fixed bitcoindevkit/rust-esplora-client#102

@tnull tnull force-pushed the 2024-10-bump-esplora-client branch from 4d9bcf1 to fc98f50 Compare December 5, 2024 12:15
@tnull tnull changed the title Bump esplora-client to 0.10 Bump esplora-client to 0.11 Dec 5, 2024
@tnull tnull requested a review from TheBlueMatt December 5, 2024 12:16
@tnull
Copy link
Contributor Author

tnull commented Dec 5, 2024

Should be good for review, now that they shipped esplora-client 0.11 which replaces the async-std dependency with a trait implementation defaulting to tokio at least, which users of this very likely already use to drive the async version.

@tnull tnull force-pushed the 2024-10-bump-esplora-client branch from fc98f50 to 426824e Compare December 5, 2024 12:18
.. the most-recent release, which also dropped the `async-std`
dependency in favor of a default sleeper implementation using `tokio`.
@tnull tnull force-pushed the 2024-10-bump-esplora-client branch from 426824e to 850952c Compare December 5, 2024 12:20
@tnull tnull added this to the 0.1 milestone Dec 9, 2024
@TheBlueMatt TheBlueMatt merged commit abf72a5 into lightningdevkit:main Dec 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants