Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after upgrade to lnd v0.13.0-beta #240

Merged
merged 5 commits into from
Jun 25, 2021
Merged

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 25, 2021

Replaces #238.

Fixes some small leftover issues after #226 was merged.

@guggero guggero requested review from Roasbeef and jamaljsr June 25, 2021 14:18
@guggero guggero changed the title Lnd 0.13 cleanup Cleanup after upgrade to lnd v0.13.0-beta Jun 25, 2021
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

guggero added 2 commits June 25, 2021 21:10
To make sure we set the log level for all registered loggers, we need to
move the call that sets the level. Since we only have one root logger,
we can only use one value for the global level. So we use the
--remote.lit-debuglevel in remote lnd mode and the --lnd.debuglevel in
integrated mode. Individual sub loggers can still be overwritten if the
following syntax is used: --lnd.debuglevel=debug,AUCT=trace for example.
We used the wrong constants for the default values of lnd's macaroon
paths. This commit sets the correct default values before the config is
parsed.
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦭

@entone
Copy link

entone commented Sep 15, 2021

Any word on when this will make it to a Docker release?

@guggero
Copy link
Member Author

guggero commented Sep 15, 2021

We'll do a minor update (v0.5.1-alpha) soon, see #265.

@entone
Copy link

entone commented Sep 15, 2021

We'll do a minor update (v0.5.1-alpha) soon, see #265.

Great, will this fix the macaroons not being created issue referenced in #241 ?

Or is that more of an LND issue, which is not being updated?

@guggero
Copy link
Member Author

guggero commented Sep 15, 2021

That should be fixed, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants