demos: update deps #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaloudis
force-pushed
the
demos-update-deps
branch
from
2abad5f to
8500559
Compare
kaloudis
force-pushed
the
demos-update-deps
branch
from
8500559 to
5a03cb7
Compare
jamaljsr
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Tested the connect-demo with no issues.
For the multi-connect-demo, I couldn't get it working. On iOS, it just displayed the loading icon forever. On Android, I received the error below. I'm not sure if there's something wrong with the demo app or an issue on my end. I followed the same steps for both demos.
|
@jamaljsr I added a new commit that will strictly check that both nodes are connecting and prevent that race condition before calling the RPC, as you experienced in the Android simulator above. As for iOS, I've been noticing it hanging in the simulator quite often and it's pushed me to deving on my iPhone X instead. Might have to address that separately. |
jamaljsr
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the demos to leverage
lnc-rnfrom npm, rather than from the project root.TODO
install-lnccommand to npm scriptsREADME