Add env vars to the grafana connection of post_start script. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Feb 5, 2024
| @@ -1,12 +1,20 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Grafana connection configuration | |||
There was a problem hiding this comment.
nit: comments should always be full sentences, including punctuation.
There was a problem hiding this comment.
Changed to "# Set your Grafana instance's connection configuration.".
| echo "Setting Grafana default dashboard..." | ||
| DASH_UID="sJUFc-NWk" | ||
| DASH_ID=0 | ||
| for i in 1 2 3 4 5; do | ||
| curl -H 'Content-Type: application/json' -X GET http://admin:admin@grafana:3000/api/dashboards/uid/$DASH_UID && RESP=$(curl -H 'Content-Type: application/json' -X GET http://admin:admin@grafana:3000/api/dashboards/uid/$DASH_UID) && DASH_ID=$( echo "$RESP" | jq '.dashboard.id' ) && break || sleep 15; | ||
| curl -H 'Content-Type: application/json' -X GET http://${GRAFANA_URI}/api/dashboards/uid/$DASH_UID && RESP=$(curl -H 'Content-Type: application/json' -X GET http://${GRAFANA_URI}/api/dashboards/uid/$DASH_UID) && DASH_ID=$( echo "$RESP" | jq '.dashboard.id' ) && break || sleep 15; |
There was a problem hiding this comment.
Should we put the full URL into double quotes to make sure white space and other special characters don't break the command?
There was a problem hiding this comment.
Still working on this.
Need to debug the quotes, maybe add escape chars somewhere.
There was a problem hiding this comment.
I removed the user:pass from the URI and explicitly set it with -u. Including quotes to handle spaces.
Hostname and port can't have spaces, unless there is an edge case I'm missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following env vars in the set_default_graf_dash.sh script, while keeping the default values in case they're not set:
This is very helpful when deploying with Docker or in a Kubernetes cluster. You can set the env vars in the docker-compose file, or your kubernetes yaml or helm charts.