dashboards: more accurate CPU usage for the perf dashboard #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, we attempt to make the current CPU usage graph for `lnd` more accurate. AFAICT, the `*10` that we had was completely superfluous, and omitting that seems to produce a more accurate CPU usage reading. In the future, we may want to use something like [`Node Exporter`](https://prometheus.io/docs/guides/node-exporter/) as we can obtain richer information such as the idle CPU time, or the amount of disk space left on the instance.
valentinewallace
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we attempt to make the current CPU usage graph for
lndmore accurate. AFAICT, the
*10that we had was completely superfluous,and omitting that seems to produce a more accurate CPU usage reading. In
the future, we may want to use something like
Node Exporteras we canobtain richer information such as the idle CPU time, or the amount of
disk space left on the instance.