collectors: add proper scraping http error logging, continue if error encountered #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, any errors that happen while lndmon is being scraped will be printed out to stdout. In the future, with a small interface wrapper, we'll also be able to add this to the regular log rotation.
Now that we log the errors, it's safe to just log and continue if prom encounters them while scraping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we hook up a proper error logger for
promhttp, which means that we'll now get error logging if Prometheus encounters an error during scraping. We also modify the default arguments to allow the scraper to continue if if runs into any errors along the way.