Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move to GitHub Actions, add workflow for building and pushing docker images #74

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

guggero
Copy link
Member

@guggero guggero commented Sep 27, 2021

Fixes #73.

lndmon is one of last LL repos that hasn't yet been updated to use GitHub Actions for the CI pipeline and doesn't yet automatically build and push docker images for each new tag.
This PR fixes both items.

@Roasbeef: We'll need to add the DOCKER_USERNAME and DOCKER_API_KEY secrets to GitHub for the automatic image push.

With this commit we move the lint and build step to GitHub Actions to
avoid using Travis for anything.
@guggero guggero requested review from Roasbeef and carlaKC September 27, 2021 08:44
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Roasbeef Roasbeef requested review from thinkmassive and removed request for Roasbeef September 27, 2021 22:48
Copy link

@thinkmassive thinkmassive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM

@guggero guggero merged commit 4500c23 into lightninglabs:master Sep 30, 2021
@guggero guggero deleted the git-actions branch September 30, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Images on Docker Hub
3 participants