-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a toggle to disable the HTLC monitor metrics #99
Add a toggle to disable the HTLC monitor metrics #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the flag, makes sense to me.
config.go
Outdated
@@ -51,6 +51,9 @@ type config struct { | |||
|
|||
// DisableGraph disables collection of graph metrics | |||
DisableGraph bool `long:"disablegraph" description:"Do not collect graph metrics"` | |||
|
|||
// DisableHtlc disables collection of HTLCs metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Bad example on the comment above, but we prefer full sentences for comments, including punctuation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted! 497ed32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I mostly meant the missing full stop 😅 Feel free to correct that for the existing comment above as well.
And can you please squash the fixup commit with the one that added the line? And usually we prefix the commits with the package that is changed (though not super strictly enforced in this repo): https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md
d76042d
to
875de5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs another squash of commits, then this is good to go. Thanks!
Awesome! want me to squash the two |
Yes, I think everything should go into a single commit. |
multi: add a toggle to disable the HTLC monitor collector
3ec0cf2
to
a03710f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌊
Over 76k entries are registered for
lnd_htlcs_resolved_htlcs
on the Prometheus endpoint in less than a week, leading to huge amounts of data being consumed by the Prometheus server (around 10MB per request).