Disable retargeting on regtest to preserve compatibility with bitcoind #256
Conversation
| @@ -2736,6 +2736,11 @@ func (b *blockManager) checkHeaderSanity(blockHeader *wire.BlockHeader, | |||
| func (b *blockManager) calcNextRequiredDifficulty(newBlockTime time.Time, | |||
| reorgAttempt bool) (uint32, error) { | |||
|
|
|||
| // bitcoind doesn't do retargeting on regtest, we do the same to ensure compatibility | |||
There was a problem hiding this comment.
This looks a bit hacky indeed... bitcoind solved it by adding another boolean to the chain params: https://github.com/bitcoin/bitcoin/blob/e695d8536e534f1e59de4a62a0d87a93e7a73456/src/kernel/chainparams.cpp#L415
Perhaps we should do the same in btcd? Then we could solve it for both Neutrino and btcd.
There was a problem hiding this comment.
This should be straightforward since blockManagerCfg has the params stored.
For reference: https://github.com/bitcoin/bitcoin/pull/6853/files
Would you be able to tweak this PR like that @amanzag? Thanks so much for addressing this inconsistency with bitcoind.
There was a problem hiding this comment.
I have a PR up in btcd that can be re-used here once merged: btcsuite/btcd#1985
No description provided.