Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapdb+rpc: return lease owner and expiry for managed UTXOs #1032

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Roasbeef
Copy link
Member

This should help us track down issues when assets aren't unlocked even
though they should be.

We also extend an existing unit test to ensure these values are properly
set.

@Roasbeef Roasbeef added enhancement New feature or request gRPC labels Jul 18, 2024
@Roasbeef Roasbeef requested review from ffranr and jharveyb July 18, 2024 23:53
@Roasbeef Roasbeef force-pushed the list-utxos-lease-info branch from fd319d3 to 55e6f68 Compare July 19, 2024 00:00
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM 🎉

@@ -417,6 +417,14 @@ type ManagedUTXO struct {
// TapscriptSibling is the serialized tapscript sibling preimage of
// this asset. This will usually be blank.
TapscriptSibling []byte

// LeaseOwner is the identifeir of the lease owner of this UTXO. If
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo in identifier.

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

@ffranr ffranr removed request for ffranr and jharveyb July 19, 2024 10:35
Roasbeef added 2 commits July 22, 2024 16:22
This should help us track down issues when assets aren't unlocked even
though they should be.

We also extend an existing unit test to ensure these values are properly
set.
@Roasbeef Roasbeef force-pushed the list-utxos-lease-info branch from 55e6f68 to 593271a Compare July 22, 2024 23:25
@Roasbeef Roasbeef enabled auto-merge July 22, 2024 23:27
@Roasbeef Roasbeef added this pull request to the merge queue Jul 22, 2024
Merged via the queue into lightninglabs:main with commit c2a5227 Jul 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gRPC
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants