makefile+scripts: specify Go version for building release binaries #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add #1045 (comment) in a different PR. |
guggero
reviewed
Jul 26, 2024
This commit updates `scripts/release.sh` to include a check for the correct Go version before executing the release build. This ensures that the release binaries are built with the specified Go version, maintaining consistency and integrity for developer signatures.
ffranr
force-pushed
the
release-gotoolchain
branch
from
9571b9e to
bea4667
Compare
|
Latest commit is just a check which returns an error if the incorrect Go version is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1045
To ensure our release binaries are reproducible, they must be built with a specific version of Go. This commit sets the
GOTOOLCHAINenvironment variable when building release binaries, ensuring that the build command uses the targeted Go version.The
GOTOOLCHAINenvironment variable is supported only in Go version 1.21 or newer. This commit verifies that the invoked Go version meets this requirement.