rpc: implement DecodeAssetInvoice #1253
Open
+1,005
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested review from
a team,
ffranr and
GeorgeTsagk
and removed request for
a team
Pull Request Test Coverage Report for Build 12398373932Details
💛 - Coveralls |
ffranr
reviewed
Dec 13, 2024
Roasbeef
force-pushed
the
decode-asset-invoice
branch
from
2f24d76 to
1924f08
Compare
Roasbeef
force-pushed
the
decode-asset-invoice
branch
from
1924f08 to
e656e8e
Compare
Roasbeef
force-pushed
the
decode-asset-invoice
branch
from
2524248 to
4cc0203
Compare
GeorgeTsagk
reviewed
Dec 17, 2024
Roasbeef
force-pushed
the
decode-asset-invoice
branch
from
4cc0203 to
57c2454
Compare
In this commit, we implement the `DecodeAssetPayReq` command. This command allows a caller to decode a normal LN invoice, adding the asset specific information along the way. This includes the corresponding asset unit amount, asset group information, and also the decimal display information. Fixes lightninglabs#1238
Roasbeef
force-pushed
the
decode-asset-invoice
branch
from
57c2454 to
610300a
Compare
guggero
approved these changes
Dec 18, 2024
|
|
||
| // assetInvoiceAmt calculates the amount of asset units to pay for an invoice | ||
| // which is expressed in sats. | ||
| func (r *rpcServer) assetInvoiceAmt(ctx context.Context, targetAsset asset.Specifier, |
There was a problem hiding this comment.
nit: line too long (linter error is somewhat cryptic).
| return 0, fmt.Errorf("error querying ask price: %w", err) | ||
| } | ||
| if oracleResp.Err != nil { | ||
| return 0, fmt.Errorf("error querying ask price: %w", err) |
There was a problem hiding this comment.
nit: use oracleResp.Err in the error message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we implement the
DecodeAssetInvoicecommand. Thiscommand allows a caller to decode a normal LN invoice, adding the asset
specific information along the way. This includes the corresponding
asset unit amount, asset group information, and also the decimal display
information.
Fixes #1238
Fixes #1166