-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: add CLI flag to enable public access to uni proof courier RPCs #499
Conversation
ef592c1
to
13de95a
Compare
I think this might already be covered by this flag? https://github.com/lightninglabs/taproot-assets/blob/main/config.go#L84 Or is this where we wan to do things like: you can send issuance proofs, but not normal transfer proofs? |
@Roasbeef I now notice that the universe RPCs are whitelisted by default. I missed that before.
This PR was supposed to be about whitelisting them via a CLI flag. I think that would be better rather than default whitelisted. Smaller attack surface for most nodes. Thanks for pointing out the I'll update the PR to what I think we should do. Please let me know if you have any thoughts on this. |
For security context. Comment from guggero: taproot-assets/tapcfg/config.go Line 701 in 575eaf7
|
13de95a
to
efa6c4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Itest is failing because of the flag, probably need to set it to true in the tapd harness. |
This commit removes the `QueryProof` and `InsertProof` RPC endpoints from the default macaroon whitelist. It also adds a CLI flag for whitelisting those endpoints. This macaroon whitelisting method mirrors that used for the universe stats endpoints.
aff1e21
to
0d72a61
Compare
Looks like the linter also found a now unused variable, then CI should be green ✔️ |
We can remove this parameter and use the macaroon whitelist to control this behaviour.
0d72a61
to
3fe7b88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎽
This PR removes the universe proof courier RPC endpoints (
QueryProof
andInsertProof
) from the default macaroon whitelist and adds a CLI flag to enable them. Which is the same method used for the universe stats RPC endpoints.This PR also removes a config param called
AcceptRemoteUniverseProofs
now that we shift access control to macaroons.