Add asset group burn itest, logging, and missing error handling #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Dec 11, 2023
ffranr
force-pushed
the
burn-asset-bug
branch
2 times, most recently
from
ff16f28 to
271fbeb
Compare
ffranr
force-pushed
the
burn-asset-bug
branch
from
271fbeb to
38148cd
Compare
GeorgeTsagk
approved these changes
Dec 12, 2023
|
|
||
| encodedGroupKey = hex.EncodeToString(assetGroupKey) | ||
| assetGroup = assetGroups.Groups[encodedGroupKey] | ||
| require.Len(t.t, assetGroup.Assets, 2) |
There was a problem hiding this comment.
I wonder if we could (in a future PR) extend this. I am curious what would happen if we burned all the amount from the second mint. Would this then have to be require.Len(t.t, assetGroup.Assets, 1) ?
|
How are we dealing with the failing vector? I think it will keep this pr from merging |
I think I might have found the issue, see #733 (comment). |
This commit adds code which handles `err != nil` which was previously absent.
This commit adds a few simple logging statements relating to the asset burn endpoint.
ffranr
force-pushed
the
burn-asset-bug
branch
from
38148cd to
2f09b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an itest which ensures that we can burn an asset from an asset group in the simplest case.
It makes the following changes to the
BurnAssetRPC endpoint:This PR was created in an attempt to re-produce bug #704