[tap channels preparation 1/?]: Add QueryInternalKey and QueryScriptKey RPCs, pre-fill script key info in vPSBT #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
tap-channels-prep-1
branch
2 times, most recently
from
9e39e8e to
3f4f12e
Compare
ffranr
reviewed
Jan 11, 2024
guggero
force-pushed
the
tap-channels-prep-1
branch
from
3f4f12e to
80c62f9
Compare
|
Thank you for the thorough review, @ffranr. I addressed all your comments. |
ffranr
approved these changes
Jan 15, 2024
guggero
force-pushed
the
tap-channels-prep-1
branch
from
80c62f9 to
f9a7286
Compare
Roasbeef
requested changes
Jan 23, 2024
|
Doesn't need a re-review, nothing major changed other than addressing @ffranr's comments. |
We'll need to be able to fetch the key family and index for an internal key of an address or asset by just specifying the internal public key. We add this method to the TapAddressBook as that already has a similar method for the script key.
When signing a virtual PSBT, we don't want to use the key descriptor info of the input asset's script key, as that information is not available when the input asset is created from a de-serialized asset. So previous to the change in this commit the SignVirtualPsbt RPC method could only be called on vPSBTs that were funded through FundVirtualPsbt that populated the key information. After this commit it is possible to sign a vPSBT that was created from an input proof only since the required key information is loaded from the database before signing.
The asset version v1 (segwit) allows an asset to be committed without the TxWitness field. Therefore, when comparing two such assets, we must also ignore the TxWitness field. If we don't do this, then the deep equal check when creating a proof for a split asset fails when checking if the split root asset was committed to the root tree.
guggero
force-pushed
the
tap-channels-prep-1
branch
from
f9a7286 to
3e7d61d
Compare
|
Comments addressed, should be good for final round of review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of preparatory commits extracted from the TAP channel simulation branch.