Custodian emits a new asset receive event commencement notification #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit the custodian is extended such that it emits an asset "receive" process start event notification to its events status subscribers.
This commit extends the asset receive events notification subscription RPC endpoint such that it can handle the new "receive start" event type.
In this commit the custodian is extended such that it keeps a limited runtime log of existing status notification events which can be optionally delivered to a new notification subscriber.
In this commit the asset receive status events subscription RPC endpoint is extended such that it will optionally deliver existing events to a new subscriber.
This commit extends an existing asset send/receive test to assert that the receiving node publishes the newly created asset receive start notification event.
ffranr
force-pushed
the
start_recv_event
branch
from
b267a08 to
a0e0a24
Compare
ffranr
commented
Feb 1, 2024
| @@ -865,6 +870,9 @@ func (c *Custodian) setReceiveCompleted(event *address.Event, | |||
| Index: lastProof.InclusionProof.OutputIndex, | |||
| } | |||
|
|
|||
| // TODO(ffranr): Remove event from local cache after | |||
| // AddrBook.CompleteEvent call. | |||
|
|
|||
There was a problem hiding this comment.
We should only publish the "receive complete" status notification to subscribers after the call to c.cfg.AddrBook.CompleteEvent. This ensures that notification is sent only if nothing fails beforehand.
|
@jharveyb: review reminder |
|
Replaced by #836. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #739
This PR changes the custodian component such that it emits a new asset receive event commencement notification to subscribers.