itest: use configurable timeout for load test #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because things can take a bit longer the more addresses and events there are, the initial proof retrieval attempt of the universe proof courier can fail, causing it to go into a 30 second backoff. Because we used a hard coded timeout of 30 seconds for the transfer to complete, this sometimes failed the load test. By making sure we use the same, configurable, timeout where relevant, we make the send process more reliable. In addition, the following lines should be added to the load test nodes to shorten the duration of the backoff: universerpccourier.initialbackoff=2s universerpccourier.maxbackoff=30s
calvinrzachman
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As investigated by @calvinrzachman, here's a small fix to make the load test more reliable.
Because things can take a bit longer the more addresses and events there are, the initial proof retrieval attempt of the universe proof courier can fail, causing it to go into a 30 second backoff. Because we used a hard coded timeout of 30 seconds for the transfer to complete, this sometimes failed the load test.
By making sure we use the same, configurable, timeout where relevant, we make the send process more reliable.
In addition, the following lines should be added to the load test nodes to shorten the duration of the backoff: