multi: add linters for switch exhaustiveness, if-else chains, and err handling #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharveyb
force-pushed
the
lint_misc_fixes
branch
from
2ddd750 to
e2c584d
Compare
In this commit, we enable extra linters to check for non-exhaustive switch statements, and if-else or switch statements that can be simplified. We also check for improper error returns and other small simplifications.
jharveyb
force-pushed
the
lint_misc_fixes
branch
from
e2c584d to
734ebf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #812. These are some lints that felt useful for keeping style consistent, as well as how we use
switch.I've added fixes for a few small issues, and lint runtime (both cold and hot module cache) on my machine increased from 13.5 to ~16 seconds.
I'm not sure which linters could be used to replicate the gopls analyzers I'm using locally, but those fixes were less important IMO.