Improve coin selection unit tests

[guggero]

Fixes #124.

[jharveyb]

Found some issues (in the unit tests) revealed by these test changes.

Put up a branch that could get pulled into this PR: https://github.com/lightninglabs/taproot-assets/tree/coin-selection-test-fixes

Looks good otherwise!

[jharveyb]

See above comment; the coin selection fix was waiting on the wrong signal; IIUC the timeout would occur for any signal since the method call was complete.

The second fix was to actually have the second asset as a reissuance into the first asset group; IIUC the test as-is was creating a duplicate asset.

[guggero]

Thanks for the review and the fixes. I took over the commit with the group anchor improvement.

IIUC the timeout would occur for any signal since the method call was complete.

That was kind of on purpose. We explicitly expect the LeaseCoins method not to be called. I agree that the timeout would occur on any other channel as well. But IMO selecting on the listSignals a second time doesn't really change that?

[jharveyb]

That was kind of on purpose. We explicitly expect the LeaseCoins method not to be called. I agree that the timeout would occur on any other channel as well. But IMO selecting on the listSignals a second time doesn't really change that?

Ah, fair enough - so any of the 3 calls timing out is sufficient.

[jharveyb]

LGTM, coverage go up 🚀

[Roasbeef]

LGTM 🎉