-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[custom channels 3/3]: add FundingController to manage channel asset funding #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks very good! Left some suggestions and clarifications to make sure we have the same flow in mind.
e437f07
to
33067d0
Compare
486831a
to
d8f3190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super exciting!
33067d0
to
d7b3b87
Compare
d7b3b87
to
f7b587a
Compare
dd47bfd
to
c7135e7
Compare
d50cee9
to
f616b28
Compare
c7135e7
to
bbcd2fb
Compare
f616b28
to
908b6f3
Compare
80b004a
to
eb7bb32
Compare
Ready for full review. |
2fc91ba
to
516c4d4
Compare
733b8b6
to
2a4ea41
Compare
516c4d4
to
370a717
Compare
2a4ea41
to
9133857
Compare
370a717
to
feea448
Compare
9133857
to
4cbfbc7
Compare
4cbfbc7
to
fc79c5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment here to consider: #882 (comment)
fc79c5b
to
c7cdf47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
In this PR, we add a new sub-system, that
FundingController
which is tasked with managing the asset channel funding process from start to finish. The new funding sub-system will communicate directly with an lnd node (in-process or via RPC) to drive the funding process with an externally funded PSBT template. We'll interact with the localAssetWallet
to funding+sign the PSBT on all levels, then ask lnd to validate what we've created, before finally broadcasting the final transaction. Before we kick off the funding process, we'll send a series of input validation proofs to the remote party. They'll validate these proofs (sent as custom messages) to ensure that we can actually sign for the assets sent.Link to all PRs in the saga:
TODO
PsbtChannelFunder