-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tapchannel: add new AuxChanCloser to enable co-op close for asset channels #919
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cb05693
tapchannel: return full chan point from FundChannel
Roasbeef f31fddd
tapcfg+tapchannel: add proof courier addr to funding proofs
Roasbeef 90f5593
asset: add UpdateTxWitness helper method
guggero 625ca3e
tapchannel: add new AuxChanCloser implementation
Roasbeef 2cb4468
rfqmsg+tapchannelmsg: add formatter for co-op close custom data
guggero 75381a8
proof: improve errors in verifyTaprootProof
Roasbeef 924e759
vm: improve errors for failed VM validation
Roasbeef c61f2a0
taprpc+rpcserver: add new EncodeCustomRecords RPC
guggero 06230d7
proof+tapgarden: fix issue with proof import
guggero 598eb04
multi: add DeclareScriptKey RPC
guggero 6479056
tapdb: allow filtering out script keys with tapscripts
guggero b0a19e8
tapfreighter: skip assets with scripted script key
guggero 14296bc
multi: add new declared_known flag to script key
guggero 6214fd8
asset: add DeclaredAsKnown and HasScriptPath to ScriptKey
guggero 8e3dcff
taprpc: add new script key flags
guggero c5e4352
tapcfg+tapchannel: register/declare funding script key
guggero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still this as something that's temp? As in we'd just wrap the payment specific stuff in an entirely new RPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes. Or maybe not, given that with this it should be pretty easy to do the RPC calls in any language. I guess the question is: how much effort is it for the app devs to call 3 RPCs (buy/sell order, encode records, send payment) with the correct values vs. us threading all the payment and channel flags through some new RPC methods in tapd...