rfq+tapchannel: track locally accepted quotes in manager #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow direct peer (zero-hop) payments, we also need to be able to look up quotes we've accepted that our peer requested. The example flow here is: Dave creates an invoice (either specifying a BTC amount or asset amount, in any case the invoice is always denominated in milli-satoshi), Charlie has a direct channel with Dave and wants to pay the invoice with assets. Charlie only sees the milli-satoshi amount of the invoice and needs to find out how many asset units to send. For that, Charlie asks Dave for a quote over the given amount of milli-satoshi, gets an asset unit amount back. Charlie then creates an HTLC referencing that asset sell quote RFQ ID. But the invoice interceptor on Dave's side would previously not recognize that RFQ ID, because it's not an ID for a quote Dave requested but one Dave accepted.
GeorgeTsagk
approved these changes
Jun 6, 2024
ffranr
approved these changes
Jun 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow direct peer (zero-hop) payments, we also need to be able to look up quotes we've accepted that our peer requested. The example flow here is: Dave creates an invoice (either specifying a BTC amount or asset amount, in any case the invoice is always denominated in milli-satoshi), Charlie has a direct channel with Dave and wants to pay the invoice with assets. Charlie only sees the milli-satoshi amount of the invoice and needs to find out how many asset units to send. For that, Charlie asks Dave for a quote over the given amount of milli-satoshi, gets an asset unit amount back. Charlie then creates an HTLC referencing that asset sell quote RFQ ID. But the invoice interceptor on Dave's side would previously not recognize that RFQ ID, because it's not an ID for a quote Dave requested but one Dave accepted.