Add custom channels min remote reserve #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
requested changes
Jun 7, 2024
| github.com/jackc/pgconn v1.14.3 | ||
| github.com/jackc/pgerrcode v0.0.0-20240316143900-6e2875d9b438 | ||
| github.com/jessevdk/go-flags v1.4.0 | ||
| github.com/jessevdk/go-flags v1.5.0 |
There was a problem hiding this comment.
Looks like you updated all available dependencies with go mod update. Please only update what's really required (lndclient) to avoid side effects.
| @@ -92,7 +98,8 @@ func (l *LndPbstChannelFunder) OpenChannel(ctx context.Context, | |||
| // taproot channel, that uses the PSBT funding flow. | |||
| taprootCommitType := lnrpc.CommitmentType_SIMPLE_TAPROOT | |||
| openChanStream, errChan, err := l.lnd.Client.OpenChannelStream( | |||
| ctx, route.NewVertex(&req.PeerPub), req.ChanAmt, 0, true, | |||
| ctx, route.NewVertex(&req.PeerPub), req.ChanAmt, | |||
| CustomChannelRemoteReserve, true, | |||
There was a problem hiding this comment.
The field you're setting here is the push amount. Are you sure we want to donate those 1k sats to the remote party?
| @@ -103,6 +110,7 @@ func (l *LndPbstChannelFunder) OpenChannel(ctx context.Context, | |||
| }, | |||
| }, | |||
| }), | |||
| lndclient.WithRemoteReserve(CustomChannelRemoteReserve), | |||
|
Integrated the commits from this PR into #939. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new const value of
1062for the remote channel reserve for custom channels. We also use that const value as the push amount when opening the channel.