Add decimal display to taprpc.Asset
#960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
requested changes
Jun 20, 2024
GeorgeTsagk
force-pushed
the
rpc-asset-decimal-display
branch
from
90c4253 to
ea8afd4
Compare
guggero
reviewed
Jun 21, 2024
guggero
reviewed
Jun 21, 2024
GeorgeTsagk
force-pushed
the
rpc-asset-decimal-display
branch
from
ea8afd4 to
441c231
Compare
GeorgeTsagk
force-pushed
the
rpc-asset-decimal-display
branch
from
441c231 to
927c173
Compare
guggero
approved these changes
Jun 21, 2024
GeorgeTsagk
force-pushed
the
rpc-asset-decimal-display
branch
from
927c173 to
21bb811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we supported a new
decimal_displayfield when minting which would be encoded in the asset metadata. This PR tries to expose that field back to the user via commonly used asset RPC calls