Add field UnconfirmedTransfers to RPC endpoint ListAssets
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
changed the title
UnconfirmedTransfersCount to RPC endpoint ListAssetsUnconfirmedTransfers to RPC endpoint ListAssets
ffranr
force-pushed
the
add-unconfirmedtransferscount-to-listassets
branch
from
5e9c769 to
dd99d6f
Compare
guggero
requested changes
Jun 25, 2024
Added a new field to the `ListAssets` RPC endpoint response. This field helps users interpret asset list responses, especially when asset coins are unconfirmed.
This commit updates an existing test to verify the new `UnconfirmedTransfers` field in the `ListAssets` RPC endpoint response.
Add clarification that this endpoint returns both confirmed and unconfirmed transfers.
ffranr
force-pushed
the
add-unconfirmedtransferscount-to-listassets
branch
from
dd99d6f to
eeb8a5b
Compare
gijswijs
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Related to @guggero 's comment earlier (#969 (comment)) I think that the Go Doc comment of QueryParcels is incorrect.
taproot-assets/tapdb/assets_store.go
Line 3020 in eeb8a5b
It should probably read something like this:
// QueryParcels returns the set of confirmed and unconfirmed parcels or exclusively the unconfirmed parcels.
Yes. But I think I'm using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new field
UnconfirmedTransfersto theListAssetsRPC endpoint response. The field is a count of unconfirmed transfers. This field helps users interpret asset list responses, especially when asset coins are unconfirmed.This change will hopeful help users understand this sort of situation: #964