Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: check out release tag before building #981

Merged
merged 1 commit into from
Jun 28, 2024
Merged

github: check out release tag before building #981

merged 1 commit into from
Jun 28, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 27, 2024

@guggero guggero requested a review from ffranr June 27, 2024 14:47
@jharveyb jharveyb self-requested a review June 27, 2024 15:49
jharveyb
jharveyb approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jharveyb jharveyb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

unit-race CI fail is known and tracked already.

@guggero guggero force-pushed the fix-release-script branch from c4f5db2 to 1f83692 Compare June 28, 2024 06:09
dstadulis
dstadulis approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty!

@dstadulis dstadulis added this pull request to the merge queue Jun 28, 2024
@dstadulis dstadulis added this to the v0.4 milestone Jun 28, 2024
Merged via the queue into main with commit ff317b4 Jun 28, 2024
16 checks passed
@guggero guggero deleted the fix-release-script branch June 28, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharveyb jharveyb jharveyb approved these changes

@dstadulis dstadulis dstadulis approved these changes

@ffranr ffranr Awaiting requested review from ffranr

Assignees

@guggero guggero

Labels
build
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@guggero @dstadulis @jharveyb