tapchannel: import funding output proofs for responder during co-op close #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
responder-coop-proof-import
branch
from
9894471 to
9de52be
Compare
Roasbeef
force-pushed
the
responder-coop-proof-import
branch
from
48c6e81 to
f8d357c
Compare
In this commit, as a prep to reuse this routine elsewhere, we decouple the method into a function.
This version includes an scid field in the close req.
…lose Otherwise, the transfer insert for the responder may fail as they don't have the funding output in their database, so shipping the transfer fails as it can't find the proof. Fixes #985.
Without this, we'll fail to fetch the proofs for a grouped asset in `importOutputProofs`.
Roasbeef
force-pushed
the
responder-coop-proof-import
branch
from
f8d357c to
a6e193d
Compare
|
Post-merge LGTM 👍🏽 |
guggero
added a commit
to guggero/lightning-terminal
that referenced
this pull request
Jul 8, 2024
Since lightninglabs/taproot-assets#987 was merged, this TODO and if statement is no longer needed to make the test pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the transfer insert for the responder may fail as they don't
have the funding output in their database, so shipping the transfer
fails as it can't find the proof.
Fixes #985.