fix comments regarding breach hint and key

lightningnetwork · Oct 23, 2024 · d24fb3b · d24fb3b
1 parent e488002
commit d24fb3b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/watchtower/lookout/lookout.go b/watchtower/lookout/lookout.go
@@ -203,7 +203,7 @@ func (l *Lookout) processEpoch(epoch *chainntnfs.BlockEpoch,
 		// The decryption key for the state update should be the full
 		// txid of the breaching commitment transaction.
 		// The decryption key for the state update should be computed as
-		//   key = SHA256(txid).
+		//   key = SHA256(txid || txid).
 		breachTxID := commitTx.TxHash()
 		breachKey := blob.NewBreachKeyFromHash(&breachTxID)
 

diff --git a/watchtower/wtclient/backup_task.go b/watchtower/wtclient/backup_task.go
@@ -339,7 +339,8 @@ func (t *backupTask) craftSessionPayload(
 
 	breachTxID := t.breachInfo.BreachTxHash
 
-	// Compute the breach key as SHA256(txid).
+	// Compute the breach hint as SHA256(txid)[:16] and breach key as
+	// SHA256(txid || txid).
 	hint, key := blob.NewBreachHintAndKeyFromHash(&breachTxID)
 
 	// Then, we'll encrypt the computed justice kit using the full breach

diff --git a/watchtower/wtclient/backup_task_internal_test.go b/watchtower/wtclient/backup_task_internal_test.go
@@ -652,7 +652,7 @@ func testBackupTask(t *testing.T, test backupTaskTest) {
 	hint, encBlob, err := task.craftSessionPayload(test.signer)
 	require.NoError(t, err, "unable to craft session payload")
 
-	// Verify that the breach hint matches the breach txid's prefix.
+	// Verify that the breach hint matches the prefix of SHA256(txid).
 	breachTxID := test.breachInfo.BreachTxHash
 	expHint := blob.NewBreachHintFromHash(&breachTxID)
 	require.Equal(t, expHint, hint)