watchtower: automatically create tor hidden service if enabled #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
reviewed
Mar 18, 2020
cfromknecht
reviewed
Mar 19, 2020
|
Updated the PR to address the comments, and also included a blurb in |
wpaulino
reviewed
Mar 24, 2020
wpaulino
reviewed
Mar 26, 2020
Co-authored-by: Turtle <orbitalturtle@protonmail.com>
This commit lets the watchtower automatically create hidden services by giving it a pointer to a TorController. The server was also slightly refactored so that it was not the sole owner of the TorController.
wpaulino
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up where #3613 left off. I think I gave credit correctly to @orbitalturtle by adding them as a Co-author in the first commit message. The old PR created two
TorContollers, one in theserver, one in the watchtower server. Now, aTorControlleris instead created inlnd.goand passed to both subsystems to avoid creating multiple connections to Tor's ControlPort.Closes #3302