htlcswitch: log fixes #4107
Merged
htlcswitch: log fixes #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crypt-iQ
added
logging
cfromknecht
reviewed
Mar 24, 2020
Roasbeef
requested changes
Mar 24, 2020
cfromknecht
reviewed
Mar 25, 2020
Crypt-iQ
force-pushed
the
switch_err_0220
branch
from
96dcf55 to
be2fbc5
Compare
This commit changes the fallback in NextLocalHtlcIndex to RemoteCommitment since the LocalHtlcIndex field lags behind on the LocalCommitment. Without this bug fix, open circuits would get prematurely trimmed, resulting in more erroneous logs. A test case is included to check that the fix works.
This commit modifies updateCommitTx to error with ErrLinkShuttingDown when we try to send a ContractUpdate on the htlcUpdates chan and the link has closed the quit chan. It also changes the order of the call to ackDownStreamPackets and contract update call for consistency since the packets should be acknowledged before the link goes down.
This commit changes the switch to only log an error if update_fail_htlc comes in and closeCircuit returns ErrUnknownCircuit. Rationale being that only settles should hit this code path, anything else is a result of a link flap and should be treated as an error.
Crypt-iQ
force-pushed
the
switch_err_0220
branch
from
be2fbc5 to
8c0c53e
Compare
cfromknecht
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error log intro'd in #3143 when pipelining settles to the switch, and makes logging less spammy and more informative. The PR breakdown is as follows:
NextLocalHtlcIndextoRemoteCommitmentsinceLocalCommitmentlags behind for theLocalHtlcIndexfield. Without this bug fix, open circuits could get prematurely trimmed, resulting in more error logs. A test case is included to check that the fix works.ErrLinkShuttingDownso that the link logs when it's getting shut down. Also changes the order of theackDownStreamPacketsand check-if-link-quit call for consistency since the packets should be ACKed before going down.update_fail_htlccomes in andcloseCircuitreturnsErrUnknownCircuit. Rationale being that only settles should hit this code path, anything else is a result of a link flap.Closes #3656