multi: cap anchors feerate at configurable maximum #4855
Conversation
fundingmanager.go
Outdated
|
|
||
| // For anchor channels cap the initial commit fee rate at our defined | ||
| // maximum. | ||
| if commitType == lnwallet.CommitmentTypeAnchors && |
There was a problem hiding this comment.
I think this'll need to check a new bit once the zero fee changes are in.
halseth
force-pushed
the
anchors-clamp-max-feerate
branch
2 times, most recently
from
8f706f1 to
e918469
Compare
| math.Max(maxFeeRate, float64(chainfee.FeePerKwFloor)), | ||
| ) | ||
|
|
||
| // Cap anchor fee rates. | ||
| if lc.channelState.ChanType.HasAnchors() && feeRate > maxAnchorFeeRate { |
There was a problem hiding this comment.
above we use commitType == lnwallet.CommitmentTypeAnchorsZeroFeeHtlcTx, should that match here? otherwise the maximum will also apply to anchor_outputs channels?
There was a problem hiding this comment.
Yes, see this commit in the zero htlc fee PR: 7b0212f#diff-e308f199858d836b06a0c920d2dd019fbb3acb7ef0d9e3d8a360601623128d78R322
So we'll always set both the anchors bit and the zero fee htlc bit if ommitType == lnwallet.CommitmentTypeAnchorsZeroFeeHtlcTx
There was a problem hiding this comment.
Correct that this'll apply to "regular" anchors as well, though with the dependent PR we essentially don't advertise it at all from teh perspective of the public network.
There was a problem hiding this comment.
Yeah, it will also apply the the existing few legacy anchor channels, but I think that's okay.
| // DefaultAnchorsCommitMaxFeeRateSatPerVByte is the default max fee rate in | ||
| // sat/vbyte the initiator will use for anchor channels. This should be enough | ||
| // to ensure propagation before anchoring down the commitment transaction. | ||
| const DefaultAnchorsCommitMaxFeeRateSatPerVByte = 10 |
halseth
force-pushed
the
anchors-clamp-max-feerate
branch
from
e918469 to
7aac569
Compare
This commit caps the update fee the initiator will send when the anchors channel type is used. We do not limit anything on the receiver side. 10 sat/vbyte is the current default max fee rate we use. This should be enough to ensure propagation before anchoring down the commitment transaction.
halseth
force-pushed
the
anchors-clamp-max-feerate
branch
from
60434d3 to
413ece2
Compare
|
Needs a rebase! |
|
Rebased |
This commit caps the update fee the initiator will send when the anchors
channel type is used. We do not limit anything on the receiver side.
10 sat/vbyte is the current default max fee rate we use. This should be
enough to ensure propagation before anchoring down the commitment
transaction.
Replaces #4795