Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: use vendored actions for steps with sensitive info #4952

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

guggero
Copy link
Collaborator

@guggero guggero commented Jan 25, 2021

To avoid leaking any sensitive information like Docker Hub credentials
because of compromised actions repositories, we use our own, vendored
actions for all steps that potentially touch sensitive information.

To avoid leaking any sensitive information like Docker Hub credentials
because of compromised actions repositories, we use our own, vendored
actions for all steps that potentially touch sensitive information.
@guggero guggero added golang/build system Related to the go language and compiler security General label for issues/PRs related to the security of the software labels Jan 25, 2021
@guggero guggero requested review from bhandras and carlaKC January 25, 2021 13:17
@guggero guggero added this to the 0.12.0 milestone Jan 25, 2021
Copy link
Collaborator

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nicee 🤩

Copy link
Collaborator

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cfromknecht cfromknecht modified the milestones: 0.12.0, 0.13.0 Jan 27, 2021
@Roasbeef Roasbeef added the P1 MUST be fixed or reviewed label Jan 28, 2021
@guggero guggero merged commit 9136405 into lightningnetwork:master Jan 28, 2021
@guggero guggero deleted the gh-actions branch January 28, 2021 09:13
@cfromknecht cfromknecht mentioned this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
golang/build system Related to the go language and compiler P1 MUST be fixed or reviewed security General label for issues/PRs related to the security of the software v0.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants