make: clean mobile stubs before building release #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix an issue where the vendor.tar.gz in a release build had a different hash if the mobile RPC stubs were in the mobile/ folder, we clean those out first. The culprit was the `google.golang.org/grpc/test/bufconn` package which is currently only used in the mobile RPC stubs and nowhere else. Therefore the vendor/module.txt was different when vendoring with the generated mobile RPC stubs being around.
halseth
approved these changes
Feb 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix an issue where the vendor.tar.gz in a release build had a
different hash if the mobile RPC stubs were in the mobile/ folder, we
clean those out first.
The culprit was the
google.golang.org/grpc/test/bufconnpackage whichis currently only used in the mobile RPC stubs and nowhere else.
Therefore the vendor/module.txt was different when vendoring with the
generated mobile RPC stubs being around.
Hash of
vendor.tar.gzwith mobile RPC stubs:29f39fa2d9f3265a9bb162d1218d851899c732f1fd3d9c9c585887f19c6fb617Hash of
vendor.tar.gzwithout mobile RPC stubs:8fb114940aed7b7b0893e6b7e1d20e0024a8d6f638fd37332d50266a3d8e2e79