discovery: use token bucket based rate limiting to throttle gossip #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Feb 11, 2021
The recently added gossip throttling was shown to be too aggressive, especially with our auto channel enable/disable signaling. We switch to a token bucket based system instead as it's based on time, rather than a block height which isn't constantly updated at a given rate.
wpaulino
force-pushed
the
new-rate-limit-chan-updates
branch
from
30ed562 to
83a0d03
Compare
wpaulino
commented
Feb 11, 2021
Comment on lines
+29
to
+37
| // DefaultMaxChannelUpdateBurst is the default maximum number of updates | ||
| // for a specific channel and direction that we'll accept over an | ||
| // interval. | ||
| DefaultMaxChannelUpdateBurst = 10 | ||
|
|
||
| // DefaultChannelUpdateInterval is the default interval we'll use to | ||
| // determine how often we should allow a new update for a specific | ||
| // channel and direction. | ||
| DefaultChannelUpdateInterval = time.Minute |
There was a problem hiding this comment.
These values were somewhat arbitrarily chosen in case reviewers have any thoughts/suggestions.
cfromknecht
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added gossip throttling was shown to be too aggressive, especially with our auto channel enable/disable signaling. We switch to a token bucket based system instead as it's based on time, rather than a block height which isn't constantly updated at a given rate.
Along the way, we also revert the commits that exposed a config flag that was only necessary for our integration tests with the previous gossip throttling logic.