routing: dial back max concurrent block fetches #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reduces the number of concurrent validation operations the router will perform when fully validating the channel graph. Reports from several users indicate that GetInfo would hang for several minutes, which is believed to be caused by attempting to validate massive amounts of channels in parallel. This commit returns the limit back to its original state before adding the batched gossip improvements. We keep the 1000 concurrent validation request limit for AssumeChannelValid, since we don't fetch blocks in that case. This allows us to still keep the performance benefits on mobile/low-resource devices.
gkrizek
added a commit
to gkrizek/lnd
that referenced
this pull request
Feb 18, 2021
This produces a race condition when reading AssumeChannelValid from a different goroutine. Instead we isolate the test cases and initial AssumeChannelValid properly.
cfromknecht
force-pushed
the
reduce-concurrent-router-validation
branch
from
eef7bbe to
250bc85
Compare
Merged
halseth
approved these changes
Feb 18, 2021
wpaulino
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reduces the number of concurrent validation operations the
router will perform when fully validating the channel graph. Reports
from several users indicate that GetInfo would hang for several minutes,
which is believed to be caused by attempting to validate massive amounts
of channels in parallel. This commit returns the limit back to its
original state before adding the batched gossip improvements.
We keep the 1000 concurrent validation request limit for
AssumeChannelValid, since we don't fetch blocks in that case. This
allows us to still keep the performance benefits on mobile/low-resource
devices.
Fixes #4892