v0.12.1-beta.rc7 #5052
Merged
v0.12.1-beta.rc7 #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a vulnerability brought up by @Kixunil where both the lnd and lncli binaries are executed to obtain their version before they have been verified against the release. A malicious binary could have already compromised the user's system before any of the checks had been performed. This commit it split out from the doc changes so that it can easily be cherry-picked to master/0.13.0.
Docker will automatically pull the image if it isn't found locally.
guggero
reviewed
Feb 23, 2021
| else | ||
| echo "ERROR: invalid number of parameters!" | ||
| echo "Usage: verify-install.sh [lnd-binary lncli-binary]" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Make sure both binaries can be found and are executable. | ||
| check_command lnd |
There was a problem hiding this comment.
This should be check_command "$LND_BIN" now. Otherwise it will check if there's an lnd in your $PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.