blockcache: add blockcache pkg and pass it to all backends #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @wpaulino |
Roasbeef
added
enhancement
wpaulino
reviewed
Mar 31, 2021
There was a problem hiding this comment.
Great work! I've been running this along with the pruned node branch for a few days and it's been working well.
|
Thanks for the review @wpaulino 😊 Updated 👍 |
carlaKC
reviewed
Apr 1, 2021
|
Thanks @carlaKC 🚀 Updated 👍 |
ellemouton
changed the title
wpaulino
reviewed
Apr 1, 2021
ellemouton
force-pushed
the
blockcache
branch
4 times, most recently
from
c39e59b to
e636b83
Compare
wpaulino
reviewed
Apr 7, 2021
wpaulino
approved these changes
Apr 7, 2021
ellemouton
force-pushed
the
blockcache
branch
2 times, most recently
from
e6db16a to
c149bb3
Compare
|
cc @Roasbeef |
|
Needs a rebase! |
|
Will be afk till Tuesday evening. Will rebase then 💪 |
|
Cool beans, rebased 👍 |
This commit adds a new blockcache package along with the GetBlock method to be used along with the blockcache.
This commit adds block cache size to the main lnd config along with the chainreg config.
This commit makes the blockcache available to BtcWallet so that any GetBlock call made to BtcWallet is wrapped by the blockcache GetBlock call.
This commit adds the block cache to the BitcoindFilteredChainView struct and wraps its GetBlock function so that block cache is used.
This commit makes the block cache available to BtcdFilteredChainView and wraps its GetBlock method so that the block cache is used.
This commit adds a blockcache pointer to BitcoindNotifier and wraps its GetBlock method so that the block cache is used.
This commit adds gives BtcdNotifier access to the block cache and wraps its GetBlock method so that it uses the block cache.
This commit initializes the nwutrino backend with the lnd blockcache so that the two can share a block cache instead of each having its own.
This commit ensures that for the neutrino implementation of lnwallet.BlockChainIO, the neutrino GetBlock method is called directly (since it already uses the blockcache). It also ensures that the block cache mutex for the given hash is locked before the call to GetBlock.
This commit adds the block cache to the CfFilteredChainView struct and wraps its GetBlock function so that block cache mutex map is used when the call to neutrino's GetBlock function is called.
This commit adds gives BtcdNotifier access to the block cache and wraps its GetBlock method so that the block cache's mutex map for the specific hash is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a blockcache package. An lnd-wide blockcache is instantiated and passed to which ever chain backend is being used.
Addresses step 1 of #5075