multi: bump Go versions #7944
multi: bump Go versions #7944
Conversation
| @@ -1,8 +1,11 @@ | |||
| module github.com/lightningnetwork/lnd/cert | |||
|
|
|||
| go 1.16 | |||
| go 1.19 | |||
There was a problem hiding this comment.
We'll need to push up tags for all modules and bump their version in the main go.mod, but I guess that's always nice to make sure we include all the latest changes.
| @@ -1,105 +1,30 @@ | |||
| github.com/aead/siphash v1.0.1/go.mod h1:Nywa3cDsYNNK3gaciGTWPwHt0wlpNV15vwmswBAUSII= | |||
There was a problem hiding this comment.
Interesting that there's such a big diff in the sum files... Did we just never run go mod tidy or did the more recent Go versions change what needs to be validated?
cert/go.mod
Outdated
| @@ -2,7 +2,10 @@ module github.com/lightningnetwork/lnd/cert | |||
|
|
|||
| go 1.19 | |||
|
|
|||
| require github.com/stretchr/testify v1.5.1 | |||
There was a problem hiding this comment.
nit: commit message should probably read "build: run go mod tidy"?
There was a problem hiding this comment.
I should have escaped the ` from git commit -m "build: run `go mod tidy`" 👍
|
Looks like the |
positiveblue
force-pushed
the
docker-build-img
branch
from
02db56f
to
bbf481c
Compare
This probably needs some good advertisement. I imagine some early noderunners are running on buster, because that was raspberry pi os until 2021-10-30. |
This only affects the base image of the Docker build. That doesn't have any impact on anyone outside of the docker image build process. You can run a |
positiveblue
force-pushed
the
docker-build-img
branch
2 times, most recently
from
aefa450
to
be3a6a9
Compare
Bump all build go versions to v1.21.0 Bump the minimum build package version to v1.19.0 Debian "buster" is not longer supported. Security updates have been discontinued since June 30th 2022. We will build using the latest version, "bookworm".
The docker image have been updated so we are using another protobuf version to generate the files. The generate files include the version of the compiler used to creating them, so we need this commit to pass the `rpc-check` step in our CI.
positiveblue
force-pushed
the
docker-build-img
branch
from
be3a6a9
to
49e099f
Compare
Bump all build go versions to v1.21.0
Bump the minimum build package version to v1.19.0
Debian "buster" is not longer supported. Security updates have been discontinued since June 30th 2022. We will build using the next version, "bullseye".