build: update to kvdb v1.4.3 #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
update-kv-db
branch
2 times, most recently
from
470cbd6
to
0fb03f7
Compare
guggero
approved these changes
Sep 6, 2023
yyforyongyu
reviewed
Sep 6, 2023
Can't remove this, since I had to modify the build tags in Otherwise plan was: merge this, tag, then new PR to do rc3 and update the module. |
Roasbeef
force-pushed
the
update-kv-db
branch
3 times, most recently
from
05b22b6
to
823e8fd
Compare
guggero
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Needs one more tweak to get the itests passing, then we're good to go:
diff --git a/itest/lnd_channel_funding_utxo_selection_test.go b/itest/lnd_channel_funding_utxo_selection_test.go
index f52af7a41..27c831351 100644
--- a/itest/lnd_channel_funding_utxo_selection_test.go
+++ b/itest/lnd_channel_funding_utxo_selection_test.go
@@ -91,7 +91,7 @@ func testChannelUtxoSelection(ht *lntest.HarnessTest) {
feeRate: 15,
expectedErrStr: "output amount(0.00000174 BTC) after " +
"subtracting fees(0.00001826 BTC) below dust " +
- "limit(0.0000033 BTC)",
+ "limit(0.00000330 BTC)",
},
// Selected coins don't cover the minimum channel size.
{
@@ -102,7 +102,7 @@ func testChannelUtxoSelection(ht *lntest.HarnessTest) {
feeRate: 1,
chanOpenShouldFail: true,
expectedErrStr: "available funds(0.00017877 BTC) " +
- "below the minimum amount(0.0002 BTC)",
+ "below the minimum amount(0.00020000 BTC)",
},
// The local amount exceeds the value of the selected coins.
{
@@ -114,7 +114,7 @@ func testChannelUtxoSelection(ht *lntest.HarnessTest) {
chanOpenShouldFail: true,
expectedErrStr: "not enough witness outputs to " +
"create funding transaction, need 0.00210337 " +
- "BTC only have 0.001 BTC available",
+ "BTC only have 0.00100000 BTC available",
},
// We are spending two selected coins partially out of three
// available in the wallet and expect a change output and the
yyforyongyu
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Pending @guggero 's comments, then this is good to go🏖
Otherwise plan was: merge this, tag, then new PR to do rc3 and update the module
This works. Just need to follow up closely as otherwise the linter will fail for other rebased PRs.
7 tasks
We needed a tag after updating the module with retry for sqlite/postgres.
In this commit, we use exhaustive build tags to ensure that we can always build the `sqlbase` package, independent of the set build tags. To do this, we move the type declarations _into_ the parsing functions. This then allows us to create two versions for each db: with the db, and without it. To avoid a module tag round trip to get this working, we use a local replace for now. Once this is merged in, we can do the tag (along side rc3), then remove the replace.
Roasbeef
force-pushed
the
update-kv-db
branch
from
823e8fd
to
0c815af
Compare
|
Unit tests for both the SQL backends failed, are those flakes? |
|
@yyforyongyu I think so, just ran then locally and it passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed a tag after updating the module with retry for sqlite/postgres.