multi: extend InvoiceDB methods with a context argument
#8066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
invoicedb-ctx
branch
from
5952472
to
81e3565
Compare
carlaKC
reviewed
Oct 6, 2023
htlcswitch/mock.go
Outdated
Comment on lines
1030
to
1035
| func (i *mockInvoiceRegistry) AddInvoice(invoice invoices.Invoice, | ||
| paymentHash lntypes.Hash) error { | ||
|
|
||
| _, err := i.registry.AddInvoice(&invoice, paymentHash) | ||
| _, err := i.registry.AddInvoice( | ||
| context.Background(), &invoice, paymentHash, | ||
| ) |
There was a problem hiding this comment.
Is ctx not passed through here because AddInvoice isn't part of the InvoiceDatabase interface? Stands out reading this that this is the only place where we have context.Background().
There was a problem hiding this comment.
No I think I just forgot to fixup this call. Done.
bhandras
force-pushed
the
invoicedb-ctx
branch
2 times, most recently
from
e4367e4
to
de1dadd
Compare
yyforyongyu
approved these changes
Oct 11, 2023
This commit adds a context to InvoiceDB's methods. Along this refactor we also extend InvoiceRegistry methods with contexts where it makes sense. This change is essential to be able to provide kvdb and sqldb implementations for InvoiceDB.
bhandras
force-pushed
the
invoicedb-ctx
branch
from
de1dadd
to
aa85972
Compare
bhandras
added
database
guggero
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of the SQL based
InvoiceDBimplementation (draft in #8052) we add context to allInvoiceDBmethods. This in turn results in some of theInvocieRegistrymethods also requiring external context passed in.Part of #6288