build: set min build version to Go 1.22.6 #9007

Roasbeef · 2024-08-14T18:40:06Z

Go 1.23 was released this week, so with this PR we update the build system to officially support the last two releases.

coderabbitai · 2024-08-14T18:40:11Z

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

guggero

Need to make linter happy, otherwise LGTM 🎉

guggero · 2024-08-15T08:26:32Z

.github/workflows/main.yml

@@ -31,7 +31,7 @@ env:
  # /dev.Dockerfile
  # /make/builder.Dockerfile
  # /.github/workflows/release.yml
-  GO_VERSION: 1.22.5
+  GO_VERSION: 1.22.6


There's now also a version in the main Makefile, which is used to check all other versions (see linter failure). So I think we could remove the above comments now, since the linter will catch any version that's not updated but should be (with one exception, we'll want to pin the version of the linter base image, as that can cause issues).

guggero · 2024-08-16T07:31:19Z

There's still one missing file: lnrpc/Dockerfile.

guggero · 2024-08-19T08:23:28Z

Linter still not happy:

 Checking for target Go version (v1.22.6) in Dockerfile files (*Dockerfile)
./scripts/check-go-version-dockerfile.sh 1.22.6
./docker/btcd/Dockerfile is using Go version 1.22.6.
./dev.Dockerfile is using Go version 1.22.6.
./lnrpc/Dockerfile is using Go version 1.22.6.
./Dockerfile is using Go version 1.22.6.
FROM golang:1.22.5-bookworm
Error: ./make/builder.Dockerfile does not use Go version 1.22.6 exclusively.
make: *** [Makefile:314: check-go-version-dockerfile] Error 1

You can also just run make go-check-version.

yyforyongyu · 2024-08-20T01:57:38Z

weird the linter is failing but make check-go-version is passing on my local machine (after updating via go work use and a rebase)

guggero · 2024-08-20T10:49:52Z

I pushed two commits that fixes the linter issue by updating it (and fixing newly discovered issues).

yyforyongyu

I got the CI passing by applying this diff, main cause is the deadline, also fixed some of the warnings, cc @guggero

diff --git a/.golangci.yml b/.golangci.yml
index 95fcec6e9..5aa6abd0e 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -1,18 +1,8 @@
 run:
-  # timeout for analysis
-  deadline: 10m
+  go: "1.22.6"
 
-  # Skip autogenerated files for mobile and gRPC as well as copied code for
-  # internal use.
-  skip-files:
-    - "mobile\\/.*generated\\.go"
-    - "\\.pb\\.go$"
-    - "\\.pb\\.gw\\.go$"
-    - "internal\\/musig2v040"
-
-  skip-dirs:
-    - channeldb/migration_01_to_11
-    - channeldb/migration/lnwire21
+  # timeout for analysis
+  timeout: 10m
 
   build-tags:
     - autopilotrpc
@@ -57,7 +47,6 @@ linters-settings:
       - G306 # Poor file permissions used when writing to a new file.
 
   staticcheck:
-    go: "1.22.6"
     checks: ["-SA1019"]
 
   lll:
@@ -219,6 +208,18 @@ issues:
   # Only show newly introduced problems.
   new-from-rev: 8c66353e4c02329abdacb5a8df29998035ec2e24
 
+  # Skip autogenerated files for mobile and gRPC as well as copied code for
+  # internal use.
+  exclude-files:
+    - "mobile\\/.*generated\\.go"
+    - "\\.pb\\.go$"
+    - "\\.pb\\.gw\\.go$"
+    - "internal\\/musig2v040"
+
+  exclude-dirs:
+    - channeldb/migration_01_to_11
+    - channeldb/migration/lnwire21
+
   exclude-rules:
     # Exclude gosec from running for tests so that tests with weak randomness
     # (math/rand) will pass the linter.

yyforyongyu · 2024-08-20T14:55:09Z

.golangci.yml

+    - gosmopolitan
+    - intrange
+
+


nit: an alternative way is to update new-from-rev: whenever we enable new linters - it may be helpful to reduce the rebase conflicts for other PRs.

yyforyongyu · 2024-08-20T17:00:51Z

ok added a commit to fix the linter CI, lets see if it passes

guggero · 2024-08-20T17:02:42Z

ok added a commit to fix the linter CI, lets see if it passes

Oops, I did the exact same... Updated the new-from-rev as well... Thanks for the diff!

Go 1.23 was released this week, so with this PR we update the build system to officially support the last two releases.

yyforyongyu

LGTM🦐

Roasbeef added the golang/build system Related to the go language and compiler label Aug 14, 2024

guggero reviewed Aug 15, 2024

View reviewed changes

Roasbeef force-pushed the go-1-22 branch 2 times, most recently from 112ab6c to 1cdffc1 Compare August 15, 2024 23:13

Roasbeef force-pushed the go-1-22 branch from 1cdffc1 to 4b7e771 Compare August 16, 2024 21:54

Roasbeef force-pushed the go-1-22 branch from 4b7e771 to 1bebbd5 Compare August 19, 2024 23:56

guggero approved these changes Aug 20, 2024

View reviewed changes

yyforyongyu reviewed Aug 20, 2024

View reviewed changes

yyforyongyu added the no-changelog label Aug 20, 2024

guggero force-pushed the go-1-22 branch from 7dee8b4 to 2313b32 Compare August 20, 2024 17:02

Roasbeef and others added 4 commits August 20, 2024 19:13

build: set min build version to Go 1.22.6

19b5a1f

Go 1.23 was released this week, so with this PR we update the build system to officially support the last two releases.

.golangci: remove or rename old and deprecated linters

9eef428

multi: update linter, fix new issues

e99e666

.golangci: fix config, update new-from-rev

3ae6553

guggero force-pushed the go-1-22 branch from 2313b32 to 3ae6553 Compare August 20, 2024 17:14

yyforyongyu approved these changes Aug 20, 2024

View reviewed changes

guggero merged commit a028064 into lightningnetwork:master Aug 20, 2024
26 of 28 checks passed

This was referenced Oct 11, 2024

release: create branch for v0.18.4-beta.rc1 #9174

Closed

release: create branch for v0.18.4-beta.rc1 #9183

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: set min build version to Go 1.22.6 #9007

build: set min build version to Go 1.22.6 #9007

Roasbeef commented Aug 14, 2024

coderabbitai bot commented Aug 14, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

guggero left a comment

guggero Aug 15, 2024

Roasbeef Aug 15, 2024

guggero commented Aug 16, 2024

guggero commented Aug 19, 2024

yyforyongyu commented Aug 20, 2024

guggero commented Aug 20, 2024

yyforyongyu left a comment

yyforyongyu Aug 20, 2024

yyforyongyu commented Aug 20, 2024

guggero commented Aug 20, 2024

yyforyongyu left a comment

build: set min build version to Go 1.22.6 #9007

build: set min build version to Go 1.22.6 #9007

Conversation

Roasbeef commented Aug 14, 2024

coderabbitai bot commented Aug 14, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

guggero left a comment

Choose a reason for hiding this comment

guggero Aug 15, 2024

Choose a reason for hiding this comment

Roasbeef Aug 15, 2024

Choose a reason for hiding this comment

guggero commented Aug 16, 2024

guggero commented Aug 19, 2024

yyforyongyu commented Aug 20, 2024

guggero commented Aug 20, 2024

yyforyongyu left a comment

Choose a reason for hiding this comment

yyforyongyu Aug 20, 2024

Choose a reason for hiding this comment

yyforyongyu commented Aug 20, 2024

guggero commented Aug 20, 2024

yyforyongyu left a comment

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)