Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Results - The "No Results" pattern is missing #143

Closed
Justinabes007 opened this issue Jul 18, 2024 · 2 comments
Closed

Search Results - The "No Results" pattern is missing #143

Justinabes007 opened this issue Jul 18, 2024 · 2 comments
Assignees
@Justinabes007
Labels
[Type] Bug Something isn't working
Milestone
1.4

Comments

@Justinabes007
Copy link
Contributor

Describe the bug
The "No Results" pattern is missing, this seems to be a parent-theme issue

screenshot (1)
@Justinabes007 Justinabes007 added the [Type] Bug Something isn't working label Jul 18, 2024
@Justinabes007 Justinabes007 added this to the 1.4 milestone Jul 18, 2024
@Justinabes007 Justinabes007 self-assigned this Jul 18, 2024
@krugazul
Copy link
Contributor

@Justinabes007 , the template is referencing a block thats not available, we need to replace it with the no results block.
https://github.com/lightspeedwp/lsx-design/blob/main/templates/search.html#L43

Justinabes007 added a commit that referenced this issue Jul 25, 2024
@Justinabes007
Search results template update
561e8b7 
No Results Block added back to template.
Template part updates to remove theme reference.
Close #143
@Justinabes007
Copy link
Contributor Author

No Results Block added back to template - 561e8b7

Tested locally & Demo, small bug fix.

@krugazul krugazul mentioned this issue Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Justinabes007 Justinabes007

Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@krugazul @Justinabes007