Adding in the CTA button variables. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @krugazul, thanks for the feedback, I am happy to merge and continue based on the suggested structure. |
Justinabes007
merged commit 03a7693
into
Colour-Palette-&-Button-Styles
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We cannot use the custom colour variables directly in the CSS files, we need to have variables in the theme.json that feeds through to there.
WordPress does not allow the customization of "styles" via the theme.json yet, but they are working on it.
WordPress/gutenberg#49602
Solution
We will add in variables to the custom node, in the format of WordPress
Resources