Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header designs with focus on Mobile #55

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Header designs with focus on Mobile #55

merged 1 commit into from
Nov 14, 2023

Conversation

Justinabes007
Copy link
Contributor

LSX Header Design improvements for Mobile

Changes made to the following template parts

Wordpress:

  • Standard
  • CTA Header
  • Dark

WooCommerce:

  • Woo Default Light
  • Woo Default Dark

Benefits

Improved Mobile experience and clean designs based on template preference.

Pre-submit checklist

As the author of this pull request, I verify that:

Testing

How to test the changes in this pull request

Follow the steps below to test the changes in this PR.

  • Deploy this branch to the dev environment.
  • Navigate to the Site Editor and select the index template.
  • Navigate to the Header settings > Change header.
  • Enable the new header template part. Save.
    Navigate to the homepage and view on Mobile screen size.

Changelog Entry

  • style.css
  • parts/header.html
  • parts/header-cta.html
  • parts/header-dark.html
  • parts/woo-header-dark.html
  • parts/woo-header-light.html
  • theme.json

@Justinabes007 Justinabes007 added the [Status] Needs Technical Feedback Needs testing from a developer perspective. label Nov 10, 2023
@Justinabes007 Justinabes007 added this to the 1.2.0 milestone Nov 10, 2023
@Justinabes007 Justinabes007 self-assigned this Nov 10, 2023
krugazul
krugazul approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@krugazul krugazul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive run through the changes to the templates, and the addition of the CTA header.

@krugazul krugazul merged commit 3ff7a5b into main Nov 14, 2023
3 of 4 checks passed
@krugazul krugazul deleted the mobile-headers branch November 14, 2023 06:30
@Justinabes007 Justinabes007 mentioned this pull request Dec 8, 2023
Closed
@krugazul krugazul mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krugazul krugazul krugazul approved these changes

Assignees

@Justinabes007 Justinabes007

Labels
[Status] Needs Technical Feedback Needs testing from a developer perspective.
Projects
No open projects
LSX
Archived in project
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Justinabes007 @krugazul