Instrument obsreport.Scraper #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
approved these changes
Nov 1, 2022
moh-osman3
added a commit
that referenced
this pull request
Nov 2, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 3, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 3, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 4, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 9, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 15, 2022
* instrument obsreport.scraper metrics with otel go
moh-osman3
added a commit
that referenced
this pull request
Nov 21, 2022
* Instrument obsreport.Scraper (#19) * instrument obsreport.scraper metrics with otel go * add changelog * update API to use MustNewScraper * fix typo add testing for checkScraperMetrics * remove accidental merge conflict references * fix references after rebase * address review comments * remove unneded log * add newlines * run gofmt * fix indenting
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* instrument obsreport.scraper metrics with otel go
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* instrument obsreport.scraper metrics with otel go
jaronoff97
added a commit
that referenced
this pull request
Dec 14, 2022
* instrument obsreport.scraper metrics with otel go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR instruments obsreport.Scraper with otel go. This is a followup PR that is based on similar changes made for obsreport.Receiver: open-telemetry#6222
Link to tracking Issue: Part of open-telemetry#816
Testing:
Ran contrib collector with prometheusreceiver and hostmetricsreceiver and confirmed that new metrics show up. Tested both with feature gate disabled and enabled.