Weights now uses trace_id to pick a choice #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Weights generates a random float for every we need to decide which element to pick.
What is the new behavior?
Weights now uses the last digits from trace_id to generate its weight when making a decision. This means that two different decisions that have the same weight, will happen at the same time.
Additionally, errors are propagated to parent spans.
Pull request checklist
Please check if your PR fulfills the following requirements:
make test
) for the changes have been added (for bug fixes / features) and passmake lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Weights will now always be deterministic within their trace_id. This means that two distinct elements tagSets vs resourceAttrSets will be consistently chose two if they have the same weights.