Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unsupported property in CMakePresets.json #182

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

sssooonnnggg
Copy link
Contributor

@sssooonnnggg sssooonnnggg commented Jul 18, 2024

This property is not documented by cmake official references and VSCode cmake tools, which causes this library can't be built when using VSCode as develop environment:
image

see: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html

@sssooonnnggg
Copy link
Contributor Author

After this fix, we can use VSCode to build usdz~😄

@syoyo
Copy link
Collaborator

syoyo commented Jul 18, 2024

Thanks! Probably such variables become deprecated when I prepared CmakePresets.json.

Do you have Visual Studio 2022 environment to test if this change also works well on VS2022?

@syoyo
Copy link
Collaborator

syoyo commented Jul 18, 2024

Hmm... I have started to get some trouble to use CMakePresets.json in VS2022

Python targets are included, and no tinyusdz_static.sln target found...

Screenshot from 2024-07-18 22-06-25

Anyway, probably we are ok to remove 'configurationType'.
Which Cmake version do you use?

@sssooonnnggg
Copy link
Contributor Author

My VS2022 seems ok, maybe it's a bug for latest VS2022 release?

image

VS version:
image

CMake version:
image

@sssooonnnggg
Copy link
Contributor Author

sssooonnnggg commented Jul 18, 2024

With this VS2022 version, build all succeeded:
image
and CMake presets work as expected😊:
image

@syoyo
Copy link
Collaborator

syoyo commented Jul 18, 2024

Nice!

Let me also know cmake version you use in VSCode. Same with VS2022?

@sssooonnnggg
Copy link
Contributor Author

VSCode use a newer CMake version: 3.23.0-rc3 and works quite well,
BTW it seems that VSCode can work better with CMakePresets because it can show tinyusdz_static target, which is not shown in VS2022, maybe VS2022 only shows debugable target, such as exe or dll, but not static libs
image

@syoyo
Copy link
Collaborator

syoyo commented Jul 18, 2024

Thanks! so it should be ok to merge PR. I will take look at some issues(e.g, no static lib target in VS2022) later

@syoyo syoyo added the enhancement New feature or request label Jul 18, 2024
@syoyo syoyo merged commit 0ba45e4 into lighttransport:dev Jul 18, 2024
14 checks passed
@syoyo
Copy link
Collaborator

syoyo commented Jul 18, 2024

Merged! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants