chore: fix missing includes of cstdint #93
Conversation
src/external/staticstruct.hh
Outdated
| @@ -26,6 +26,7 @@ | |||
| #include <limits> | |||
| #include <memory> | |||
| #include <stack> | |||
| #include <cstdint> | |||
There was a problem hiding this comment.
Can you help me from which library this is coming from to provide a fix upstream?
There was a problem hiding this comment.
std::uint32_t is used in line 131
There was a problem hiding this comment.
Thanks PR! staticstruct is now legacy and not used in tinyusdz. We should remote staticstruct. Let me give some time to work on removing it.
There was a problem hiding this comment.
FYI staticstruct git repo is here: https://github.com/syoyo/staticstruct
|
Thanks! I have removed I think we should go with
Good to know! |
This fixes compilation of this library using clang++-18 on Ubuntu 23.10.
|
Rebased onto newest |
|
Thanks! Merged! |
Thank you for this awesome library!
I had a small problem when compiling using clang. This fixes compilation of this library using clang++-18 on Ubuntu 23.10 where it was missing a few includes of
<cstdint>.Please let me know whether you prefer
<cstdint>or the deprecated<stdint.h>. At least in one of the cases<cstdint>has to be used to providestd::unt32_tdefinitions.<cstdint>does not define::uint32_tas defined by the C++, onlystd::uint32_tbut in practice it also defines::uint32_tfor all implementation that I'm aware of.