fix Mercurial tests and add tag validation #102
Conversation
src/Liip/RMT/Config/Handler.php
Outdated
| throw new Exception("Simple generator is not compatible with mercurial > 3."); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
I don't know if it's the right place to put this mercurial specific code... At first I was more expecting a new method on the VCS interface. Something like supportTaggingWithInteger(). But then the error have to be raised after the config have been parsed, at the beginning of the releaseaction...
There was a problem hiding this comment.
I wasn't really happy about this either.
Maybe a validateConfig on VcsInterface ?
krtek4
changed the title
| $action->validateContext(); | ||
| } | ||
| } | ||
| Context::get('version-persister')->validateContext(); |
There was a problem hiding this comment.
Why not a validateContext() on the version-generator?
There was a problem hiding this comment.
As discussed, because the generator work is a bit different than the other actions and the persister and there's no need at the time.
Adding it once we need it won't be a big issue.
Can we merge ? please, pretty please, PLEASE ! PLEASE !
|
There is two last issues, my small comment about the |
|
@jeanmonod Whats with this PR? We should integrate the HG Tag check. All my HG tests are failing because of this. |
|
doing a minimal fix of the tests without the full improvement and better error reporting in #130 |
This should fix #77
What do you think @jeanmonod ?